Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: APPS-3072 remove icon in BlockTag from BlockCardThreeColumn #657

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat: APPS-3072 remove icon in BlockTag from BlockCardThreeColumn #657

merged 1 commit into from
Nov 21, 2024

Conversation

farosFreed
Copy link
Contributor

@farosFreed farosFreed commented Nov 20, 2024 •
edited
Loading

Connected to APPS-3072

Component Edited: BlockCardThreeColumn.vue

Notes:

BlockCardThreeColumn will no longer put the guest-speaker icon in tags it renders

Checklist:

  • I checked that it is working locally in the dev server
  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
  • I added a screenshot of it working
  • UX has reviewed and approved this
  • I assigned this PR to someone on the dev team to review
  • I used a conventional commit message
  • I assigned myself to this PR

@farosFreed farosFreed added the feature feature label Nov 20, 2024
@farosFreed farosFreed self-assigned this Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-657--ucla-library-storybook.netlify.app

@farosFreed farosFreed marked this pull request as ready for review November 20, 2024 22:23
@farosFreed farosFreed merged commit 1efc83e into main Nov 21, 2024
13 checks passed
@farosFreed farosFreed deleted the APPS-3072_remove-icon-name-blockthreecolumn branch November 21, 2024 16:51
pghorpade pushed a commit that referenced this pull request Nov 21, 2024
@semantic-release-bot
chore(release): set package.json to 3.34.0 [skip ci]
18eb0bc 
# [3.34.0](v3.33.0...v3.34.0) (2024-11-21)

### Features

* APPS-3072 remove icon in BlockTag from BlockCardThreeColumn ([#657](#657)) ([1efc83e](1efc83e))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinuola tinuola tinuola approved these changes

Assignees

@farosFreed farosFreed

Labels
feature feature released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farosFreed @pghorpade @tinuola